Generate noop CI step if next (is only available during the FF) is N.A #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donoghuc
reviewed
Dec 14, 2024
donoghuc
previously approved these changes
Dec 14, 2024
There was a problem hiding this comment.
I think this is fine, suggest using get for this https://github.com/elastic/logstash-filter-elastic_integration/pull/206/files#r1884665016 , but dont block on that if you need to update in a ton of places 😅
mashhurs
commented
Dec 14, 2024
Co-authored-by: Cas Donoghue <[email protected]>
💚 Build Succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Oops, snapshot next stack version can be null since it is only available during the FF. I covered it in the pull-request pipeline and forgot noop placeholder in build/E2E pipeline where this PR covers.
CI state